gh-109162: Refactor libregrtest.RunTests #109177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename dash_R() runtest_refleak(). The function now gets huntrleaks and quiet arguments, instead of 'ns' argument. * Add attributes to Regrtest and RunTests: * verbose * quiet * huntrleaks * test_dir * Add HuntRefleak class.
AlexWaygood
reviewed
Sep 9, 2023
| nwarmup, ntracked, fname = ns.huntrleaks | ||
| fname = os.path.join(os_helper.SAVEDCWD, fname) | ||
| repcount = nwarmup + ntracked | ||
| warmups = hunt_refleak.warmups |
There was a problem hiding this comment.
Looks like this has broken all of the refleak buildbots: https://buildbot.python.org/all/#/builders/474/builds/1335/steps/5/logs/stdio
There was a problem hiding this comment.
They are all failing in the same way on #109197
There was a problem hiding this comment.
Ah. A test is missing apparently. I wrote PR #109202 to fix the regression and add a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename dash_R() runtest_refleak(). The function now gets huntrleaks and quiet arguments, instead of 'ns' argument.
Add attributes to Regrtest and RunTests:
Add HuntRefleak class.