Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-109118: Disallow nested scopes within PEP 695 scopes within classes #109196

Merged
merged 5 commits into from Sep 12, 2023
Merged

gh-109118: Disallow nested scopes within PEP 695 scopes within classes #109196

merged 5 commits into from Sep 12, 2023

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Sep 9, 2023 •
edited by bedevere-bot

@JelleZijlstra JelleZijlstra added the needs backport to 3.12 bug and security fixes label Sep 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Sep 9, 2023
Closed
carljm
carljm approved these changes Sep 11, 2023
View reviewed changes
Lib/test/test_type_params.py Outdated Show resolved Hide resolved
@JelleZijlstra @carljm
Update Lib/test/test_type_params.py
ea69d36 
Co-authored-by: Carl Meyer <carl@oddbird.net>
@JelleZijlstra JelleZijlstra merged commit b88d9e7 into python:main Sep 12, 2023
23 checks passed
@miss-islington
Copy link
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@JelleZijlstra JelleZijlstra deleted the fixclassgenexp branch September 12, 2023 00:11
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2023
@JelleZijlstra @carljm @miss-islington
pythongh-109118: Disallow nested scopes within PEP 695 scopes within …
0dc03f4 
…classes (pythonGH-109196)

Fixes pythonGH-109118. Fixes pythonGH-109194.

(cherry picked from commit b88d9e7)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Carl Meyer <carl@oddbird.net>
@bedevere-app
Copy link

bedevere-app bot commented Sep 12, 2023

GH-109297 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 12, 2023
Yhg1s pushed a commit that referenced this pull request Sep 12, 2023
@miss-islington @JelleZijlstra @carljm
[3.12] gh-109118: Disallow nested scopes within PEP 695 scopes within…
8208657 
… classes (GH-109196) (#109297)

gh-109118: Disallow nested scopes within PEP 695 scopes within classes (GH-109196)

Fixes GH-109118. Fixes GH-109194.

(cherry picked from commit b88d9e7)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Carl Meyer <carl@oddbird.net>
vstinner pushed a commit to vstinner/cpython that referenced this pull request Sep 13, 2023
@JelleZijlstra @carljm @vstinner
pythongh-109118: Disallow nested scopes within PEP 695 scopes within …
cc1f90e 
…classes (python#109196)

Fixes python#109118. Fixes python#109194.

Co-authored-by: Carl Meyer <carl@oddbird.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm carljm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with comprehension inlining + type aliases Annotation scopes containing nested scopes
4 participants
@JelleZijlstra @miss-islington @carljm @bedevere-bot