New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode #109423
Conversation
Use a longer key: FIPS mode requires at least of at least 112 bits. The previous key was only 32 bits.
I tested manually that the change fix test_socket on the affected RHEL8 FIPS buildbot:
|
By the way, this buildbot is running:
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…nGH-109423) Use a longer key: FIPS mode requires at least of at least 112 bits. The previous key was only 32 bits. (cherry picked from commit e091b9f) Co-authored-by: Victor Stinner <vstinner@python.org>
GH-109426 is a backport of this pull request to the 3.12 branch. |
GH-109427 is a backport of this pull request to the 3.11 branch. |
…nGH-109423) Use a longer key: FIPS mode requires at least of at least 112 bits. The previous key was only 32 bits. (cherry picked from commit e091b9f) Co-authored-by: Victor Stinner <vstinner@python.org>
|
The affected buildbot turned green (success): https://buildbot.python.org/all/#/builders/469/builds/6002 :-) It is the first time that it becomes green for a long time. It was failing for at least 3 weeks, but it's likely that it was never green. |
Use a longer key: FIPS mode requires at least of at least 112 bits. The previous key was only 32 bits.