Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even more PyDoc_STR #109487

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Even more PyDoc_STR #109487

wants to merge 4 commits into from

Conversation

Gobot1234
Copy link
Contributor

@Gobot1234 Gobot1234 commented Sep 16, 2023

Similar to #109393 I also chose to add this to StructSequences because they seem to be doing a similiar thing

Regex used ((PyGetSetDef|PyMemberDef|PyMethodDef|PyStructSequence_Field|PyStructSequence_Desc) .* = \{ [\s\S]* .*?"(?<!\))\}|\{Py_tp_doc, ")

Regex used ((PyGetSetDef|PyMemberDef|PyMethodDef|PyStructSequence_Field|PyStructSequence_Desc) .* = \{
[\s\S]*
.*?"(?<!\))\}|\{Py_tp_doc, ")
@rhettinger rhettinger removed their request for review September 28, 2023 02:30
@Gobot1234
Copy link
Contributor Author

@sobolevn would you mind reviewing this?

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff was rather hard to review, since there are so many changed files.

Plus, this generates quite a lot of blame changes for important pieces of code.

(This is just a statement for others to keep in mind, I still think that this is a proper bug fix).

Modules/_multiprocessing/semaphore.c Outdated Show resolved Hide resolved
Modules/_winapi.c Outdated Show resolved Hide resolved
Modules/_xxtestfuzz/_xxtestfuzz.c Outdated Show resolved Hide resolved
Modules/cjkcodecs/cjkcodecs.h Outdated Show resolved Hide resolved
Objects/fileobject.c Outdated Show resolved Hide resolved
Python/sysmodule.c Outdated Show resolved Hide resolved
Python/sysmodule.c Outdated Show resolved Hide resolved
Python/sysmodule.c Outdated Show resolved Hide resolved
Python/sysmodule.c Outdated Show resolved Hide resolved
Python/sysmodule.c Outdated Show resolved Hide resolved
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants