Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-109653: Improve enum import time by avoiding import of functools #109789

Merged
merged 1 commit into from
Sep 23, 2023
Merged

gh-109653: Improve enum import time by avoiding import of functools #109789

merged 1 commit into from
Sep 23, 2023
+3 −3

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Sep 23, 2023 •
edited by bedevere-app bot

This reduces the import time of enum by over 50% on my machine (PGO-optimised, non-debug build on Windows), from around 0.007s to around 0.003s

@bedevere-app bedevere-app bot mentioned this pull request Sep 23, 2023
Closed
@AlexWaygood AlexWaygood added performance Performance or resource usage 3.13 bugs and security fixes type-feature A feature request or enhancement stdlib Python modules in the Lib dir labels Sep 23, 2023
@ethanfurman ethanfurman merged commit 51863b7 into python:main Sep 23, 2023
30 checks passed
@AlexWaygood AlexWaygood deleted the enum-import-time branch September 23, 2023 18:32
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@AlexWaygood @csm10495
pythongh-109653: Improve enum import time by avoiding import of `fu…
9087a14 
…nctools` (pythonGH-109789)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees
No one assigned
Labels
3.13 bugs and security fixes performance Performance or resource usage stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexWaygood @JelleZijlstra @ethanfurman