Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-109631: Allow interruption of short repeated regex matches #109867

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 25, 2023

Counting for signal checking now continues in new match from the point where it ended in the previous match instead of starting from 0.

Counting for signal checking now continues in new match from the point where
it ended in the previous match instead of starting from 0.
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error performance Performance or resource usage 3.12 bugs and security fixes 3.13 bugs and security fixes labels Sep 25, 2023
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple.

@serhiy-storchaka serhiy-storchaka merged commit 8ac2085 into python:main Sep 26, 2023
29 checks passed
@serhiy-storchaka serhiy-storchaka deleted the re-interrupt-repeated-matches branch September 26, 2023 07:56
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes and removed 3.12 bugs and security fixes 3.13 bugs and security fixes labels Sep 26, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2023
…ythonGH-109867)

Counting for signal checking now continues in new match from the point where
it ended in the previous match instead of starting from 0.
(cherry picked from commit 8ac2085)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2023
…ythonGH-109867)

Counting for signal checking now continues in new match from the point where
it ended in the previous match instead of starting from 0.
(cherry picked from commit 8ac2085)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 26, 2023

GH-109885 is a backport of this pull request to the 3.11 branch.

@bedevere-app
Copy link

bedevere-app bot commented Sep 26, 2023

GH-109886 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Sep 26, 2023
serhiy-storchaka added a commit that referenced this pull request Sep 26, 2023
…H-109867) (GH-109885)

Counting for signal checking now continues in new match from the point where
it ended in the previous match instead of starting from 0.
(cherry picked from commit 8ac2085)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
…ythonGH-109867)

Counting for signal checking now continues in new match from the point where
it ended in the previous match instead of starting from 0.
Yhg1s pushed a commit that referenced this pull request Oct 2, 2023
…H-109867) (#109886)

gh-109631: Allow interruption of short repeated regex matches (GH-109867)

Counting for signal checking now continues in new match from the point where
it ended in the previous match instead of starting from 0.
(cherry picked from commit 8ac2085)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance or resource usage type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants