Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-110045: Update symtable module for PEP 695 #110066

Merged
merged 4 commits into from
Sep 29, 2023
Merged

gh-110045: Update symtable module for PEP 695 #110066

merged 4 commits into from
Sep 29, 2023

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Sep 29, 2023 •
edited by bedevere-app bot

@JelleZijlstra JelleZijlstra added the needs backport to 3.12 bug and security fixes label Sep 29, 2023
@bedevere-app bedevere-app bot mentioned this pull request Sep 29, 2023
Closed
@wookayin
Copy link

wookayin commented Sep 29, 2023 •
edited

... and also the docstring for get_type :)

@carljm
Copy link
Member

carljm commented Sep 29, 2023

The documentation for get_type in Doc/library/symtable.rst should also be updated. (Probably with a versionchanged to indicate the new values only appear in 3.12.)

@JelleZijlstra
Copy link
Member Author

The documentation for get_type in Doc/library/symtable.rst should also be updated. (Probably with a versionchanged to indicate the new values only appear in 3.12.)

Good call. I also updated the get_name docs with the names of the new scope types.

@JelleZijlstra JelleZijlstra enabled auto-merge (squash) September 29, 2023 01:37
@JelleZijlstra JelleZijlstra merged commit 7dc2c50 into python:main Sep 29, 2023
22 of 23 checks passed
@miss-islington
Copy link
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2023
@JelleZijlstra @miss-islington
pythongh-110045: Update symtable module for PEP 695 (pythonGH-110066)
48e067f 
(cherry picked from commit 7dc2c50)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 29, 2023

GH-110070 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 29, 2023
@JelleZijlstra JelleZijlstra deleted the updatesymtab branch September 29, 2023 03:15
Yhg1s pushed a commit that referenced this pull request Sep 29, 2023
@miss-islington @JelleZijlstra
[3.12] gh-110045: Update symtable module for PEP 695 (GH-110066) (#11…
69a9f47 
…0070)

gh-110045: Update symtable module for PEP 695 (GH-110066)
(cherry picked from commit 7dc2c50)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm carljm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JelleZijlstra @wookayin @carljm @miss-islington