Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.12 What's New: Remove duplicate "up to" #110219

Merged
merged 1 commit into from
Oct 2, 2023
Merged

3.12 What's New: Remove duplicate "up to" #110219

merged 1 commit into from
Oct 2, 2023

Conversation

numbermaniac
Copy link
Contributor

@numbermaniac numbermaniac commented Oct 2, 2023 •
edited by github-actions bot

I spotted a typo while reading the What's New page that said "producing tokens via the tokenize module is up to up to 64% faster." This PR removes one of the "up to"s.

📚 Documentation preview 📚: https://cpython-previews--110219.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 2, 2023
AlexWaygood
AlexWaygood approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood enabled auto-merge (squash) October 2, 2023 13:07
@AlexWaygood AlexWaygood added the needs backport to 3.12 bug and security fixes label Oct 2, 2023
@AlexWaygood AlexWaygood merged commit 8d92b6e into python:main Oct 2, 2023
29 checks passed
@miss-islington
Copy link
Contributor

Thanks @numbermaniac for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2023
@numbermaniac @miss-islington
3.12 What's New: Remove duplicate "up to" (pythonGH-110219)
dd7d817 
(cherry picked from commit 8d92b6e)

Co-authored-by: numbermaniac <5206120+numbermaniac@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 2, 2023

GH-110220 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 2, 2023
@numbermaniac numbermaniac deleted the patch-1 branch October 2, 2023 13:15
@AA-Turner
Copy link
Member

I must have proof-read this section four or five times! Thanks @numbermaniac.

A

Yhg1s pushed a commit that referenced this pull request Oct 2, 2023
@miss-islington @numbermaniac
[3.12] 3.12 What's New: Remove duplicate "up to" (GH-110219) (#110220)
8296b53 
3.12 What's New: Remove duplicate "up to" (GH-110219)
(cherry picked from commit 8d92b6e)

Co-authored-by: numbermaniac <5206120+numbermaniac@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@numbermaniac @miss-islington @AA-Turner @AlexWaygood