Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-110590: Fix _sre.compile error overwrite #110591

Merged
merged 5 commits into from
Oct 10, 2023
Merged

gh-110590: Fix _sre.compile error overwrite #110591

merged 5 commits into from
Oct 10, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 10, 2023 •
edited by bedevere-app bot

PyLong_AsUnsignedLong strikes back 😉

@bedevere-app bedevere-app bot mentioned this pull request Oct 10, 2023
Closed
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Oct 10, 2023
@erlend-aasland erlend-aasland enabled auto-merge (squash) October 10, 2023 09:32
@erlend-aasland erlend-aasland merged commit 344d3a2 into python:main Oct 10, 2023
27 checks passed
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2023
@sobolevn @miss-islington
pythongh-110590: Fix a bug where _sre.compile would overwrite excepti…
7ab8b37 
…ons (pythonGH-110591)

TypeError would be overwritten by OverflowError
if 'code' param contained non-ints.
(cherry picked from commit 344d3a2)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Oct 10, 2023

GH-110613 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 10, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2023
@sobolevn @miss-islington
pythongh-110590: Fix a bug where _sre.compile would overwrite excepti…
530247b 
…ons (pythonGH-110591)

TypeError would be overwritten by OverflowError
if 'code' param contained non-ints.
(cherry picked from commit 344d3a2)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Oct 10, 2023

GH-110614 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 10, 2023
erlend-aasland pushed a commit that referenced this pull request Oct 10, 2023
@miss-islington @sobolevn
[3.11] gh-110590: Fix a bug where _sre.compile would overwrite except…
7fefed0 
…ions (GH-110591) (#110614)

TypeError would be overwritten by OverflowError
if 'code' param contained non-ints.
(cherry picked from commit 344d3a2)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
erlend-aasland pushed a commit that referenced this pull request Oct 10, 2023
@miss-islington @sobolevn
[3.12] gh-110590: Fix a bug where _sre.compile would overwrite except…
c1e8e90 
…ions (GH-110591) (#110613)

TypeError would be overwritten by OverflowError
if 'code' param contained non-ints.
(cherry picked from commit 344d3a2)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sobolevn @miss-islington @erlend-aasland