Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-104584: Fix refleak when tracing through calls #110593

Merged
merged 3 commits into from Oct 10, 2023
Merged

GH-104584: Fix refleak when tracing through calls #110593

merged 3 commits into from Oct 10, 2023

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Oct 10, 2023 •
edited by bedevere-app bot

This modifies _PyFunction_LookupByVersion to return a borrowed reference, which is what the caller assumes (and most internal "lookup" functions do, in general).

@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Oct 10, 2023
@brandtbucher brandtbucher self-assigned this Oct 10, 2023
@brandtbucher brandtbucher changed the title GH-104854: Fix refleak when tracing through calls GH-104584: Fix refleak when tracing through calls Oct 10, 2023
@bedevere-app bedevere-app bot mentioned this pull request Oct 10, 2023
Open
gvanrossum
gvanrossum approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I love how this already violates a likely future C API requirement. Glad that those requirements don't apply to internal APIs. :-)

@brandtbucher brandtbucher enabled auto-merge (squash) October 10, 2023 08:15
@brandtbucher brandtbucher merged commit 13380da into python:main Oct 10, 2023
31 of 32 checks passed
@gvanrossum gvanrossum deleted the uops-refleak branch October 10, 2023 09:57
@gvanrossum gvanrossum mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

@brandtbucher brandtbucher

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandtbucher @gvanrossum