Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-110696: Fix incorrect syntax error message for incorrect argument unpacking #110706

Merged
merged 6 commits into from Oct 12, 2023

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 11, 2023

Copy link
Contributor

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit.

Grammar/python.gram Outdated Show resolved Hide resolved
Grammar/python.gram Outdated Show resolved Hide resolved
Copy link
Contributor

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pablogsal pablogsal enabled auto-merge (squash) October 11, 2023 14:50
@pablogsal pablogsal enabled auto-merge (squash) October 11, 2023 14:50
@lysnikolaou
Copy link
Contributor

Tests are failing still.

@pablogsal pablogsal merged commit 3d18034 into python:main Oct 12, 2023
27 checks passed
@pablogsal pablogsal deleted the gh-110696 branch October 12, 2023 09:02
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3d180347ae73119bb51500efeeafdcd62bcc6f78 3.12

@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3d180347ae73119bb51500efeeafdcd62bcc6f78 3.11

@bedevere-app
Copy link

bedevere-app bot commented Oct 12, 2023

GH-110765 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 12, 2023
pablogsal added a commit to pablogsal/cpython that referenced this pull request Oct 12, 2023
…ect argument unpacking (pythonGH-110706)

(cherry picked from commit 3d18034)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this pull request Oct 12, 2023
…ect argument unpacking (pythonGH-110706)

(cherry picked from commit 3d18034)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 12, 2023

GH-110766 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 12, 2023
pablogsal added a commit that referenced this pull request Oct 12, 2023
pablogsal added a commit to pablogsal/cpython that referenced this pull request Oct 13, 2023
… incorrect argument unpacking (pythonGH-110706) (cherry picked from commit 3d18034)
pablogsal added a commit that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants