gh-110864: Partially revert 110784, constraints cannot be NULL
#110922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot be `NULL`
sobolevn
changed the title
constraints cannot be NULLconstraints cannot be NULL
sobolevn
changed the title
constraints cannot be NULLconstraints cannot be NULL
sobolevn
changed the title
constraints cannot be NULLconstraints cannot be NULL
Objects/typevarobject.c
Outdated
| Py_XDECREF(bound); | ||
| return NULL; | ||
| } | ||
| if (!PyTuple_CheckExact(constraints)) { |
There was a problem hiding this comment.
Maybe we can actually turn this into an assert? If I understand correctly, AC should guarantee it's always a tuple.
JelleZijlstra
approved these changes
Oct 16, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
… `constraints` cannot be `NULL` (python#110922)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also changed the exception message to be uppercase, like all others are.
Refs #110784
Refs #110868