Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-101100: Fix sphinx warnings in library/asyncio-dev.rst #111179

Merged
merged 3 commits into from Oct 22, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 22, 2023

Please, note that this change is not about asyncio-eventloop.rst, but is about asyncio-dev.rst which just happens to reference asyncio-eventloop.rst:

/Users/sobolev/Desktop/cpython/Doc/library/asyncio-dev.rst:60: WARNING: py:attr reference target not found: loop.slow_callback_duration

I've also fixed one asyncio-eventloop.rst problem, which cannot be detected by Sphinx (just because I saw it):
Снимок экрана 2023-10-22 в 17 09 31

I've moved the .. versionchanged inside the function body.

In the next PR I will fix warnings specific to asyncio-eventloop.rst.


📚 Documentation preview 📚: https://cpython-previews--111179.org.readthedocs.build/

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sobolevn for the PR. I've added a small clarification to the attribute definition.

Doc/library/asyncio-eventloop.rst Outdated Show resolved Hide resolved
Doc/library/asyncio-eventloop.rst Outdated Show resolved Hide resolved
@willingc willingc enabled auto-merge (squash) October 22, 2023 17:05
@willingc willingc merged commit 8c689c9 into python:main Oct 22, 2023
24 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2023
…thonGH-111179)

* pythongh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`

* Update Doc/library/asyncio-eventloop.rst

* Update Doc/library/asyncio-eventloop.rst

---------

(cherry picked from commit 8c689c9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2023
…thonGH-111179)

* pythongh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`

* Update Doc/library/asyncio-eventloop.rst

* Update Doc/library/asyncio-eventloop.rst

---------

(cherry picked from commit 8c689c9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 22, 2023

GH-111185 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 22, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 22, 2023

GH-111186 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 22, 2023
willingc added a commit that referenced this pull request Oct 22, 2023
…H-111179) (#111185)

gh-101100: Fix sphinx warnings in `library/asyncio-dev.rst` (GH-111179)

* gh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`

* Update Doc/library/asyncio-eventloop.rst

* Update Doc/library/asyncio-eventloop.rst

---------

(cherry picked from commit 8c689c9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
willingc added a commit that referenced this pull request Oct 22, 2023
…H-111179) (#111186)

gh-101100: Fix sphinx warnings in `library/asyncio-dev.rst` (GH-111179)

* gh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`

* Update Doc/library/asyncio-eventloop.rst

* Update Doc/library/asyncio-eventloop.rst

---------

(cherry picked from commit 8c689c9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…thonGH-111179)

* pythongh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`

* Update Doc/library/asyncio-eventloop.rst

* Update Doc/library/asyncio-eventloop.rst

---------

Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants