gh-105704: Disallow IPv6 URLs with invalid prefix/suffix

[bcail]

• Issue: urlparse does not flag hostname *containing* [ or ] as incorrect #105704

[cpython-cla-bot]

The following commit authors need to sign the Contributor License Agreement:

• bcail@crossway.org

Click the button to sign:

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[pschoen-itsc]

@bcail Would it be possible to also add a test case for having a bracket in the username / password? Because this is case where the current implementation fails for me, but it should work according to the referenced spec.

[bcail]

@pschoen-itsc Sure, if there's consensus. What about this comment? Doesn't that comment argue that the spec says that brackets in the username/password should be percent-encoded?

[pschoen-itsc]

@bcail There was a breaking change which wasn't covered by the tests. So at least we should habe tests which cover the spec (not the "faulty" implementation before 3.11.4).
Just my opinion.

(Edited because to stupid to read...)

[bcail]

Here's the description of what characters should be encoded in user info.

Looks like we don't currently check for characters (like [) that must be percent-encoded, and we don't decode them - the username and password are just left however they come in.

@orsenthil Do we want to add some checking for characters that weren't properly encoded, and should we decode the encoded characters in the username/password?

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[bcail]

I also just pushed a commit that adds the checking for bytes URLs as well.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.