Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-59703: use the dladdr instead of deprecated macOS APIs in getpath.c #111546

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

aisk
Copy link
Member

@aisk aisk commented Oct 31, 2023

The GA does not run the tests with --enable-framework, so how can we test the change?

@ned-deily
Copy link
Member

@python/macos-team

@ronaldoussoren
Copy link
Contributor

The GA does not run the tests with --enable-framework, so how can we test the change?

Could you explain what you mean?

@chrstphrchvz
Copy link
Contributor

chrstphrchvz commented Nov 5, 2023

The GA does not run the tests with --enable-framework, so how can we test the change?

Could you explain what you mean?

I am not the PR author, but to try to explain this: the proposed changes to getpath.c affect code which is only compiled when WITH_NEXT_FRAMEWORK is defined, which is only the case when the configure script is run with --enable-framework. But the GitHub Actions CI for macOS does not do this, so the proposed changes have not been fully tested by the CI.

@ronaldoussoren
Copy link
Contributor

A relevant issue for this is #59703, which contains an ancient patch that uses basically the same solution (but is outdated otherwise).

@ned-deily : is this something you can easily test on a number of macOS versions? I can currently only test on macOS 14 and 13, and I'd prefer to have test results on at least one version before 11.0 before changing the way we merge this.

@ned-deily
Copy link
Member

Will do

@ned-deily
Copy link
Member

To test, I cherry-picked the PR to the current head of 3.12 and built a current python.org-style 10.9+ universal2 installer. I then installed on and ran the usual test suite on: macOS 14.1 (Apple Silicon and Intel), macOS 11 (Apple Silicon), macOS 10.13 (Intel), and macOS 10.9 (Intel). I did not notice any regressions from the 3.12.0 release. So, while not a comprehensive test and not testing any effects on embedded uses, I think we could go ahead with this for 3.13.

@ned-deily ned-deily merged commit de2715f into python:main Nov 21, 2023
30 checks passed
@aisk aisk deleted the remove-deprecated-macos branch November 21, 2023 06:38
ned-deily added a commit to ned-deily/cpython that referenced this pull request Nov 21, 2023
@ned-deily
Copy link
Member

FTR, this PR introduced a regression for older macOS releases that was corrected by #112309. Both PRs were included in 3.13.0a2.

aisk added a commit to aisk/cpython that referenced this pull request Feb 11, 2024
… framework builds (pythonGH-111546)

Co-authored-by: Ned Deily <nad@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants