GH-110894: Call loop exception handler for exceptions in client_connected_cb #111601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kumaraditya303
commented
Nov 1, 2023
•
kumaraditya303
commented
- Issue: Asyncio stream doesn't handle exceptions in callback #110894
kumaraditya303
requested review from
1st1,
asvetlov,
gvanrossum and
willingc
as code owners
kumaraditya303
added
topic-asyncio
needs backport to 3.11
|
Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @kumaraditya303, I could not cleanly backport this to |
|
Sorry, @kumaraditya303, I could not cleanly backport this to |
|
GH-111632 is a backport of this pull request to the 3.12 branch. |
kumaraditya303
added a commit
to kumaraditya303/cpython
that referenced
this pull request
Nov 2, 2023
… client_connected_cb (pythonGH-111601) Call loop exception handler for exceptions in `client_connected_cb` of `asyncio.start_server` so that applications can handle it.. (cherry picked from commit 229f44d) Co-authored-by: Kumar Aditya <kumaraditya@python.org>
|
|
kumaraditya303
added a commit
to kumaraditya303/cpython
that referenced
this pull request
Nov 2, 2023
… client_connected_cb (pythonGH-111601) Call loop exception handler for exceptions in `client_connected_cb` of `asyncio.start_server` so that applications can handle it.. (cherry picked from commit 229f44d) Co-authored-by: Kumar Aditya <kumaraditya@python.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The test fails on many buildbots: see previous comments and issue #111644. |
FullteaR
pushed a commit
to FullteaR/cpython
that referenced
this pull request
Nov 3, 2023
…_connected_cb (python#111601) Call loop exception handler for exceptions in `client_connected_cb` of `asyncio.start_server` so that applications can handle it.
|
@kumaraditya303 Please revert this ASAP. CI is failing on main, meaning we cannot merge bug fixes for other issues. |
I fixed the issue with PR #111713. Sadly, on existing PRs, either failing jobs should be re-run, or the PR should be rebased on the main branch.
@kumaraditya303: Do you plan to backport the change to 3.11? If yes, please include my fix in your backport ;-) |
Oh, PR #111634 already exists. I included my fix in this backport. |
vstinner
added a commit
that referenced
this pull request
Nov 4, 2023
…n client_connected_cb (GH-111601) (GH-111632) (#111634) * [3.12] GH-110894: Call loop exception handler for exceptions in client_connected_cb (GH-111601) (GH-111632) (cherry picked from commit 9aa8829) Co-authored-by: Kumar Aditya <kumaraditya@python.org> Call loop exception handler for exceptions in `client_connected_cb` of `asyncio.start_server` so that applications can handle it.. (cherry picked from commit 229f44d) * gh-111644: Fix asyncio test_unhandled_exceptions() (#111713) Fix test_unhandled_exceptions() of test_asyncio.test_streams: break explicitly a reference cycle. Fix also StreamTests.tearDown(): the loop must not be closed explicitly, but using set_event_loop() which takes care of shutting down the executor with executor.shutdown(wait=True). BaseEventLoop.close() calls executor.shutdown(wait=False). (cherry picked from commit ac01e22) --------- Co-authored-by: Kumar Aditya <kumaraditya@python.org> Co-authored-by: Victor Stinner <vstinner@python.org>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…_connected_cb (python#111601) Call loop exception handler for exceptions in `client_connected_cb` of `asyncio.start_server` so that applications can handle it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.