Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mock_open docstring to use readline #11176

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Fix mock_open docstring to use readline #11176

merged 1 commit into from
Dec 20, 2018

Conversation

tirkarthi
Copy link
Member

This should be readline instead of methoddline. I think this is trivial and doesn't need a bpo and NEWS entry.

@tirkarthi
Copy link
Member Author

Friendly ping @mariocj89 @cjw296

mariocj89
mariocj89 approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@mariocj89 mariocj89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense :) @cjw296 can set up the labels to skip issue news entry.

@cjw296 cjw296 merged commit 71f82a2 into python:master Dec 20, 2018
@miss-islington
Copy link
Contributor

Thanks @tirkarthi for the PR, and @cjw296 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@cjw296: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2018
@tirkarthi @miss-islington
Fix mock_open docstring to use readline (pythonGH-11176)
1d3b805 
(cherry picked from commit 71f82a2)

Co-authored-by: Xtreak <tirkarthi@users.noreply.github.com>
@bedevere-bot
Copy link

GH-11266 is a backport of this pull request to the 3.7 branch.

@cjw296 cjw296 mentioned this pull request Dec 20, 2018
Closed
@tirkarthi
Copy link
Member Author

Thanks @cjw296 and @mariocj89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariocj89 mariocj89 mariocj89 approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tirkarthi @miss-islington @bedevere-bot @mariocj89 @cjw296 @the-knights-who-say-ni