Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-112332: Deprecate TracebackException.exc_type, add exc_type_str. #112333

Merged
merged 5 commits into from Nov 28, 2023
Merged

gh-112332: Deprecate TracebackException.exc_type, add exc_type_str. #112333

merged 5 commits into from Nov 28, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Nov 23, 2023 •
edited by github-actions bot

@bedevere-app bedevere-app bot mentioned this pull request Nov 23, 2023
Closed
@iritkatriel iritkatriel mentioned this pull request Nov 23, 2023
Closed
@iritkatriel iritkatriel added type-feature A feature request or enhancement stdlib Python modules in the Lib dir 3.13 bugs and security fixes labels Nov 23, 2023
ericsnowcurrently
ericsnowcurrently approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Nov 28, 2023 •
edited

Thanks for doing this, @iritkatriel. I agree it's a better solution than what I had proposed.

@ericsnowcurrently ericsnowcurrently mentioned this pull request Nov 28, 2023
Closed
@iritkatriel iritkatriel merged commit 2c68011 into python:main Nov 28, 2023
29 checks passed
@iritkatriel iritkatriel deleted the traceback_exc_type branch November 28, 2023 12:45
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@iritkatriel @aisk
pythongh-112332: Deprecate TracebackException.exc_type, add exc_type_…
4289b72 
…str. (python#112333)
@davidism davidism mentioned this pull request May 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
3.13 bugs and security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate TracebackException.exc_type
2 participants
@iritkatriel @ericsnowcurrently