Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101336: Add keep_alive keyword parameter for AbstractEventLoop.create_server() and BaseEventLoop.create_server() #112485

Merged
merged 4 commits into from Dec 13, 2023
Merged

gh-101336: Add keep_alive keyword parameter for AbstractEventLoop.create_server() and BaseEventLoop.create_server() #112485

merged 4 commits into from Dec 13, 2023

Conversation

beavailable
Copy link
Contributor

@beavailable beavailable commented Nov 28, 2023 •
edited by bedevere-app bot

@beavailable
gh-101336: Add keep_alive keyword parameter for `AbstractEventLoop.…
9de26ae 
…create_server()` and `BaseEventLoop.create_server()`
@bedevere-app bedevere-app bot mentioned this pull request Nov 28, 2023
Closed
gvanrossum
gvanrossum approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This seems pretty useful and the implementation looks dead simple.

I'm fixing some markup in Misc/NEWS.d, then I'll merge. Thanks!

@gvanrossum gvanrossum enabled auto-merge (squash) December 13, 2023 03:07
@gvanrossum gvanrossum merged commit 3aea6c4 into python:main Dec 13, 2023
31 checks passed
@beavailable beavailable deleted the fix-issue-101336 branch December 13, 2023 04:00
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@beavailable @aisk
pythongh-101336: Add keep_alive keyword arg for asyncio create_server…
5349f77 
…() (python#112485)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beavailable @gvanrossum