gh-112625: Protect bytearray from being freed by misbehaving iterator inside bytearray.join #112626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chilaxan
commented
Dec 2, 2023
•
chilaxan
commented
- Issue: stringlib bytearray.join function has the potential to leak memory when used with a custom iterator #112625
serhiy-storchaka
added
needs backport to 3.11
|
Would you mind to add a NEWS entry? You can use blurb-it for this. |
Misc/NEWS.d/next/Core and Builtins/2023-12-03-19-34-51.gh-issue-112625.QWTlwS.rst
Outdated
Show resolved
Hide resolved
…e-112625.QWTlwS.rst
|
Thanks @chilaxan for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-112693 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 4, 2023
…erator inside bytearray.join (pythonGH-112626) (cherry picked from commit 0e732d0) Co-authored-by: chilaxan <chilaxan@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 4, 2023
…erator inside bytearray.join (pythonGH-112626) (cherry picked from commit 0e732d0) Co-authored-by: chilaxan <chilaxan@gmail.com>
|
GH-112694 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 4, 2023
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 4, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…erator inside bytearray.join (pythonGH-112626)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.