Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-112645: remove deprecation warning for use of onerror in shutil.rmtree #112659

Merged
merged 5 commits into from Dec 3, 2023
Merged

gh-112645: remove deprecation warning for use of onerror in shutil.rmtree #112659

merged 5 commits into from Dec 3, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Dec 3, 2023 •
edited by github-actions bot

@bedevere-app bedevere-app bot mentioned this pull request Dec 3, 2023
Closed
AlexWaygood
AlexWaygood reviewed Dec 3, 2023
View reviewed changes
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
@AlexWaygood AlexWaygood added the needs backport to 3.12 bug and security fixes label Dec 3, 2023
@iritkatriel @AlexWaygood
Update Doc/whatsnew/3.12.rst
efd0846 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
serhiy-storchaka
serhiy-storchaka approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onexc also can be deprecated soon. I am planning to add an error handler with different interface.

@iritkatriel iritkatriel merged commit 97857ac into python:main Dec 3, 2023
31 checks passed
@miss-islington-app
Copy link

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @iritkatriel, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 97857ac0580057c3a4f75d34209841c81ee11a96 3.12

iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Dec 3, 2023
@iritkatriel
pythongh-112645: remove deprecation warning for use of onerror in shu…
dcd1eac 
…til.rmtree (python#112659)

(cherry picked from commit 97857ac)
@bedevere-app
Copy link

bedevere-app bot commented Dec 3, 2023

GH-112665 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Dec 3, 2023
iritkatriel added a commit that referenced this pull request Dec 3, 2023
@iritkatriel
[3.12] gh-112645: remove deprecation warning for use of onerror in sh…
f5965c2 
…util.rmtree (#112659) (#112665)

gh-112645: remove deprecation warning for use of onerror in shutil.rmtree (#112659)

(cherry picked from commit 97857ac)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@iritkatriel @aisk
pythongh-112645: remove deprecation warning for use of onerror in shu…
1184fe3 
…til.rmtree (python#112659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@iritkatriel iritkatriel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undeprecate the onerror argument in shutil.rmtree()
3 participants
@iritkatriel @serhiy-storchaka @AlexWaygood