-
-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-112779: Check 1-byte atomics in configure #112819
Conversation
See https://gcc.godbolt.org/z/rPbrns6P8:
|
I will take a look at this weekend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good to me.
But would you like to leave a comment why 1-byte atomic checking and 8-byte atomic is checking is needed with compiler version issue?
In the future, we need to know why the check-ing was needed but without comment, it could be easily forgotten.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This fixes RISC-V compilation for GCC versions earlier than GCC 13.
GCC versions 12 and earlier require libatomic library support for 1-byte and 2-byte atomics on RISC-V, but not for 8-byte atomics. The configure script only checked 8-byte atomics and so did not think that
-latomic
was necessary.GCC 13 already worked. It does not require libatomic support for any of the sizes we use (1, 2, 4, or 8 bytes).