Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101100: Improve documentation for attributes on instance methods #112832

Merged
merged 1 commit into from Dec 8, 2023
Merged

gh-101100: Improve documentation for attributes on instance methods #112832

merged 1 commit into from Dec 8, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Dec 7, 2023 •
edited

Gets rid of around 10 Sphinx warnings.

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting core review labels Dec 7, 2023
@bedevere-app bedevere-app bot mentioned this pull request Dec 7, 2023
Open
@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Dec 7, 2023
@AlexWaygood
Copy link
Member Author

Docs preview: https://cpython-previews--112832.org.readthedocs.build/en/112832/reference/datamodel.html#instance-methods

hugovk
hugovk approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹📚📚

@AlexWaygood AlexWaygood merged commit ed21d0c into python:main Dec 8, 2023
31 checks passed
@AlexWaygood AlexWaygood deleted the method-attr-docs branch December 8, 2023 13:18
@miss-islington-app
Copy link

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 8, 2023
@AlexWaygood @miss-islington
pythongh-101100: Improve documentation for attributes on instance met…
0534b27 
…hods (pythonGH-112832)

(cherry picked from commit ed21d0c)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 8, 2023

GH-112872 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Dec 8, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 8, 2023
@AlexWaygood @miss-islington
pythongh-101100: Improve documentation for attributes on instance met…
250b281 
…hods (pythonGH-112832)

(cherry picked from commit ed21d0c)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 8, 2023

GH-112873 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Dec 8, 2023
AlexWaygood added a commit that referenced this pull request Dec 8, 2023
@miss-islington @AlexWaygood
[3.11] gh-101100: Improve documentation for attributes on instance me…
161cfd0 
…thods (GH-112832) (#112873)

gh-101100: Improve documentation for attributes on instance methods (GH-112832)
(cherry picked from commit ed21d0c)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Dec 8, 2023
@miss-islington @AlexWaygood
[3.12] gh-101100: Improve documentation for attributes on instance me…
b39e90e 
…thods (GH-112832) (#112872)

gh-101100: Improve documentation for attributes on instance methods (GH-112832)
(cherry picked from commit ed21d0c)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood AlexWaygood mentioned this pull request Jan 19, 2024
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@AlexWaygood @aisk
pythongh-101100: Improve documentation for attributes on instance met…
db79645 
…hods (python#112832)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexWaygood @hugovk