gh-86179: Avoid making case-only changes when calculating realpath() during initialization #113077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zooba
commented
Dec 14, 2023
•
zooba
commented
- Issue: venv on Windows with symlinks is broken if invoked with -I #86179
…ath() during initialization
|
!buildbot windows |
|
🤖 New build scheduled with the buildbot fleet by @zooba for commit a56fac8 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
| @@ -535,7 +540,11 @@ getpath_realpath(PyObject *Py_UNUSED(self) , PyObject *args) | |||
| len -= 4; | |||
| } | |||
| } | |||
| result = PyUnicode_FromWideChar(p, len); | |||
| if (CompareStringOrdinal(path, (int)pathlen, p, len, TRUE) == CSTR_EQUAL) { | |||
There was a problem hiding this comment.
Can pathlen be larger than INT_MAX?
There was a problem hiding this comment.
No, and if it is, we'll have failed earlier because the API can't handle more than 32K worth of path.
corona10
pushed a commit
to corona10/cpython
that referenced
this pull request
Dec 15, 2023
…ath() during initialization (pythonGH-113077)
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ath() during initialization (pythonGH-113077)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.