-
-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-113280: Fix ResourceWarning in ssl.SSLSocket connected detection #113282
Conversation
graingert
commented
Dec 19, 2023
•
edited by bedevere-app
bot
edited by bedevere-app
bot
- Issue: ResourceWarning in ssl.SSLSocket connected detection #113280
97b76b3
to
9c36721
Compare
3d88a5f
to
a9b6d88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can self.close()
raise OSError in these cases?
How difficult to write tests?
I'm pretty sure self.close() doesn't raise anything, but if it did it would be raised when It's tricky to test as I only managed to reproduce this intermittently |
Several lines below an OSError raised by I wonder whether such guard is needed in these cases. |
I think |
|