Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-113214: Fix SSLProto exception handling in SSL-over-SSL scenarios #113334

Merged
merged 2 commits into from
Dec 20, 2023
Merged

GH-113214: Fix SSLProto exception handling in SSL-over-SSL scenarios #113334

merged 2 commits into from
Dec 20, 2023

Commits on Dec 20, 2023

  1. Fix SSLProto exception handling in SSL-over-SSL scenarios 

    When wrapped, `_SSLProtocolTransport._force_close(exc)` is called just like in the unwrapped scenario `_SelectorTransport._force_close(exc)` or `_ProactorBasePipeTransport._force_close(exc)` would be called, except here the exception needs to be passed through the `SSLProtocol._abort()` method, which didn't accept an exception object.

This commit ensures that this path works, in the same way that the uvloop implementation of SSLProto passes on the exception (on which the current implementation of SSLProto is based).
    @mjpieters
    mjpieters committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    8049c8c View commit details
    Browse the repository at this point in the history

  2. 📜🤖 Added by blurb_it.

    @blurb-it @mjpieters
    blurb-it[bot] authored and mjpieters committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    998504d View commit details
    Browse the repository at this point in the history