GH-110109: Fix misleading pathlib._abc.PurePathBase
repr
#113376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PurePathBase.__repr__()
produces a string likeMyPath('/foo')
. This repr is incorrect/misleading when a subclass's__init__()
method is customized, which I expect to be the very common.This PR moves the
__repr__()
method toPurePath
, leavingPurePathBase
with the defaultobject
repr.No user-facing changes because the
pathlib._abc
module remains private.Downstream
pathlib_abc
issue: barneygale/pathlib-abc#6