Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.12] gh-114021: Pin various sphinxcontrib extensions to older versions #114022

Merged
merged 3 commits into from
Jan 13, 2024
Merged

[3.12] gh-114021: Pin various sphinxcontrib extensions to older versions #114022

merged 3 commits into from
Jan 13, 2024

Conversation

ronaldoussoren
Copy link
Contributor

@ronaldoussoren ronaldoussoren commented Jan 13, 2024 •
edited

This PR pins a number of sphinxcontrib extensions to ensure they can be used with the version of Sphinx used to build the documentation.

📚 Documentation preview 📚: https://cpython-previews--114022.org.readthedocs.build/

@ronaldoussoren
pythongh-114021: Pin sphinxcontrib-applehelp to 1.0.4
8c4bdac 
This is the last version supporting sphinx < 5.
@bedevere-app bedevere-app bot mentioned this pull request Jan 13, 2024
Closed
@hugovk hugovk changed the title gh-114021: Pin sphinxcontrib-applehelp to 1.0.4 [3.12] gh-114021: Pin sphinxcontrib-applehelp to 1.0.4 Jan 13, 2024
@ronaldoussoren ronaldoussoren added the needs backport to 3.11 only security fixes label Jan 13, 2024
@ronaldoussoren ronaldoussoren changed the title [3.12] gh-114021: Pin sphinxcontrib-applehelp to 1.0.4 [3.12] gh-114021: Pin various sphinxcontrib extensions to older versions Jan 13, 2024
@mdickinson mdickinson mentioned this pull request Jan 13, 2024
Merged
@AA-Turner AA-Turner merged commit 94b1d1f into python:3.12 Jan 13, 2024
21 checks passed
@miss-islington-app
Copy link

Thanks @ronaldoussoren for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 13, 2024
@ronaldoussoren @miss-islington
[3.12] pythongh-114021: Pin various sphinxcontrib extensions to older…
01c497a 
… versions (pythonGH-114022)

(cherry picked from commit 94b1d1f)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 13, 2024

GH-114029 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Jan 13, 2024
AA-Turner pushed a commit that referenced this pull request Jan 13, 2024
@miss-islington @ronaldoussoren
[3.11] gh-114021: Pin various sphinxcontrib extensions to older versi…
25af45d 
…ons (GH-114022) (#114029)

[3.12] gh-114021: Pin various sphinxcontrib extensions to older versions (GH-114022)
(cherry picked from commit 94b1d1f)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@hugovk
Copy link
Member

hugovk commented Jan 13, 2024

3.8-3.10 are also failing, backport to those too?

https://github.com/python/python-docs-theme/actions/runs/7514253170

@AA-Turner AA-Turner added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jan 13, 2024
@miss-islington-app
Copy link

Thanks @ronaldoussoren for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @ronaldoussoren for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @ronaldoussoren for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @ronaldoussoren and @AA-Turner, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 94b1d1fa38ada8cf7d196184a04a195c152eed75 3.9

@miss-islington-app
Copy link

Sorry, @ronaldoussoren and @AA-Turner, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 94b1d1fa38ada8cf7d196184a04a195c152eed75 3.8

@miss-islington-app
Copy link

Sorry, @ronaldoussoren and @AA-Turner, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 94b1d1fa38ada8cf7d196184a04a195c152eed75 3.10

AA-Turner pushed a commit to AA-Turner/cpython that referenced this pull request Jan 13, 2024
@ronaldoussoren @AA-Turner
[3.10] [3.12] pythongh-114021: Pin various sphinxcontrib extensions t…
2fbf1ef 
…o older versions (pythonGH-114022).

(cherry picked from commit 94b1d1f)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
AA-Turner pushed a commit to AA-Turner/cpython that referenced this pull request Jan 13, 2024
@ronaldoussoren @AA-Turner
[3.9] [3.12] pythongh-114021: Pin various sphinxcontrib extensions to…
8f1d368 
… older versions (pythonGH-114022).

(cherry picked from commit 94b1d1f)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
AA-Turner pushed a commit to AA-Turner/cpython that referenced this pull request Jan 13, 2024
@ronaldoussoren @AA-Turner
[3.8] [3.12] pythongh-114021: Pin various sphinxcontrib extensions to…
8732f67 
… older versions (pythonGH-114022).

(cherry picked from commit 94b1d1f)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 13, 2024

GH-114038 is a backport of this pull request to the 3.10 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.10 only security fixes label Jan 13, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jan 13, 2024

GH-114039 is a backport of this pull request to the 3.9 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.9 only security fixes label Jan 13, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jan 13, 2024

GH-114040 is a backport of this pull request to the 3.8 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.8 only security fixes label Jan 13, 2024
ambv pushed a commit that referenced this pull request Jan 17, 2024
@AA-Turner @ronaldoussoren
[3.8] gh-114021: Pin various sphinxcontrib extensions to older versio…
a911516 
…ns (GH-114022) (GH-114040)

(cherry picked from commit 94b1d1f)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
ambv pushed a commit that referenced this pull request Jan 17, 2024
@AA-Turner @ronaldoussoren
[3.9] gh-114021: Pin various sphinxcontrib extensions to older versio…
2613df8 
…ns (GH-114022) (GH-114039)

(cherry picked from commit 94b1d1f)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
ambv pushed a commit that referenced this pull request Jan 17, 2024
@AA-Turner @ronaldoussoren
[3.10] gh-114021: Pin various sphinxcontrib extensions to older versi…
6661b22 
…ons (GH-114022) (GH-114038)

(cherry picked from commit 94b1d1f)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees

@AA-Turner AA-Turner

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ronaldoussoren @hugovk @AA-Turner