gh-112532: Improve mimalloc page visiting #114133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for visiting abandoned pages in mimalloc and improves the performance of the page visiting code. Abandoned pages contain memory blocks from threads that have exited. At some point, they may be later reclaimed by other threads. We still need to visit those pages in the free-threaded GC because they contain live objects. This also reduces the overhead of visiting mimalloc pages: * Special cases for full, empty, and pages containing only a single block. * Fix free_map to use one bit instead of one byte per block. * Use fast integer division by a constant algorithm when computing block offset from block size and index.
DinoV
reviewed
Jan 17, 2024
| } | ||
|
|
||
| // Visit all blocks in a abandoned segments | ||
| bool _mi_abandoned_pool_visit_blocks(mi_abandoned_pool_t* pool, uint8_t page_tag, bool visit_blocks, mi_block_visit_fun* visitor, void* arg) { |
There was a problem hiding this comment.
This (and therefore the previous 2 functions) doesn't seem to be used anywhere?
There was a problem hiding this comment.
These will be used in the upcoming GC PR. Here is an example usage:
I put them in this PR because:
- Keeping the mimalloc changes separate makes them a bit easier to track and upstream
- The GC PR will be big and doing this first makes the upcoming PR a bit smaller
|
@DinoV, would you please merge this when you are ready? |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
This adds support for visiting abandoned pages in mimalloc and improves the performance of the page visiting code. Abandoned pages contain memory blocks from threads that have exited. At some point, they may be later reclaimed by other threads. We still need to visit those pages in the free-threaded GC because they contain live objects. This also reduces the overhead of visiting mimalloc pages: * Special cases for full, empty, and pages containing only a single block. * Fix free_map to use one bit instead of one byte per block. * Use fast integer division by a constant algorithm when computing block offset from block size and index.
daanx
added a commit
to microsoft/mimalloc
that referenced
this pull request
Jun 3, 2024
daanx
added a commit
to microsoft/mimalloc
that referenced
this pull request
Jun 3, 2024
daanx
added a commit
to microsoft/mimalloc
that referenced
this pull request
Jun 3, 2024
daanx
added a commit
to microsoft/mimalloc
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for visiting abandoned pages in mimalloc and improves the performance of the page visiting code. Abandoned pages contain memory blocks from threads that have exited. At some point, they may be later reclaimed by other threads. We still need to visit those pages in the free-threaded GC because they contain live objects.
This also reduces the overhead of visiting mimalloc pages: