gh-114887 Reject only sockets of type SOCK_STREAM in create_datagram_endpoint(), improve exception message. #114893

tjhowse · 2024-02-02T06:43:15Z

Details in #114887.

Issue: create_datagram_endpoint() no longer compatible with CAN bus raw sockets #114887

cpython-cla-bot · 2024-02-02T06:43:18Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2024-02-02T06:43:22Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app · 2024-02-02T06:59:53Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app · 2024-02-02T07:55:29Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

gvanrossum

LGTM. Can you add a brief blurb? Then I'll merge it.

Misc/NEWS.d/next/Core and Builtins/2024-02-03-04-07-18.gh-issue-114887.uLSFmN.rst

Co-authored-by: Donghee Na <donghee.na92@gmail.com>

gvanrossum · 2024-02-03T16:49:16Z

Is it worth backporting to 3.12 and 3.11?

bedevere-bot · 2024-02-03T18:09:08Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 Refleaks NoGIL 3.x has failed when building commit 94ec2b9.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1368/builds/112) and take a look at the build logs.
Check if the failure is related to this commit (94ec2b9) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1368/builds/112

Failed tests:

test.test_concurrent_futures.test_init

Test leaking resources:

test_init: memory blocks

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/util.py", line 296, in _run_finalizers
    finalizer()
    ~~~~~~~~~^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/util.py", line 220, in __call__
    res = self._callback(*self._args, **self._kwargs)
          ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/synchronize.py", line 87, in _cleanup
    sem_unlink(name)
    ~~~~~~~~~~^^^^^^
FileNotFoundError: [Errno 2] No such file or directory
Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/util.py", line 296, in _run_finalizers
    finalizer()
    ~~~~~~~~~^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/util.py", line 220, in __call__
    res = self._callback(*self._args, **self._kwargs)
          ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/synchronize.py", line 87, in _cleanup
    sem_unlink(name)
    ~~~~~~~~~~^^^^^^
FileNotFoundError: [Errno 2] No such file or directory
Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/util.py", line 296, in _run_finalizers
    finalizer()
    ~~~~~~~~~^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/util.py", line 220, in __call__
    res = self._callback(*self._args, **self._kwargs)
          ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/synchronize.py", line 87, in _cleanup
    sem_unlink(name)
    ~~~~~~~~~~^^^^^^
FileNotFoundError: [Errno 2] No such file or directory
Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/util.py", line 296, in _run_finalizers
    finalizer()
    ~~~~~~~~~^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/util.py", line 220, in __call__
    res = self._callback(*self._args, **self._kwargs)
          ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/synchronize.py", line 87, in _cleanup
    sem_unlink(name)
    ~~~~~~~~~~^^^^^^
FileNotFoundError: [Errno 2] No such file or directory
Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/util.py", line 296, in _run_finalizers
    finalizer()
    ~~~~~~~~~^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/util.py", line 220, in __call__
    res = self._callback(*self._args, **self._kwargs)
          ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/synchronize.py", line 87, in _cleanup
    sem_unlink(name)
    ~~~~~~~~~~^^^^^^
FileNotFoundError: [Errno 2] No such file or directory
Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/util.py", line 296, in _run_finalizers
    finalizer()
    ~~~~~~~~~^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/util.py", line 220, in __call__
    res = self._callback(*self._args, **self._kwargs)
          ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/multiprocessing/synchronize.py", line 87, in _cleanup
    sem_unlink(name)
    ~~~~~~~~~~^^^^^^
FileNotFoundError: [Errno 2] No such file or directory

…agram_endpoint() (python#114893) Also improve exception message. Co-authored-by: Donghee Na <donghee.na92@gmail.com>

tjhowse · 2024-02-03T23:17:27Z

Is it worth backporting to 3.12 and 3.11?

I think so, as we're currently running 3.11.x in our application. PRs raised: #114977 and #114978

…ate_datagram_endpoint() (pythonGH-114893) Also improve exception message. (cherry picked from commit 94ec2b9) Co-authored-by: Travis Howse <tjhowse@gmail.com> Co-authored-by: Donghee Na <donghee.na92@gmail.com>

bedevere-app · 2024-02-03T23:57:47Z

GH-114979 is a backport of this pull request to the 3.11 branch.

bedevere-app · 2024-02-03T23:57:55Z

GH-114980 is a backport of this pull request to the 3.12 branch.

tjhowse · 2024-02-03T23:59:03Z

Is it worth backporting to 3.12 and 3.11?

I think so, as we're currently running 3.11.x in our application. PRs raised: #114977 and #114978

Hm, I seem to have botched the format of the branch names. New PRs raised: #114979 #114980

…agram_endpoint() (python#114893) Also improve exception message. Co-authored-by: Donghee Na <donghee.na92@gmail.com>

tjhowse added 2 commits February 2, 2024 16:00

Accept SOCK_DGRAM and SOCK_RAW socket types in create_datagram_endpoint

85f934f

Flip the comparison to reject SOCK_STREAMs

e8504d3

tjhowse requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners February 2, 2024 06:43

bedevere-app bot added the awaiting review label Feb 2, 2024

bedevere-app bot mentioned this pull request Feb 2, 2024

create_datagram_endpoint() no longer compatible with CAN bus raw sockets #114887

Closed

Merge branch 'main' into fix-issue-differently-114887

c726aa8

Update test to reflect new exception wording.

efadced

gvanrossum reviewed Feb 2, 2024

View reviewed changes

📜🤖 Added by blurb_it.

cb1d428

corona10 reviewed Feb 3, 2024

View reviewed changes

Misc/NEWS.d/next/Core and Builtins/2024-02-03-04-07-18.gh-issue-114887.uLSFmN.rst Outdated Show resolved Hide resolved

serhiy-storchaka reviewed Feb 3, 2024

View reviewed changes

Misc/NEWS.d/next/Core and Builtins/2024-02-03-04-07-18.gh-issue-114887.uLSFmN.rst Outdated Show resolved Hide resolved

Fix markup in blurb

69ea35d

Co-authored-by: Donghee Na <donghee.na92@gmail.com>

gvanrossum enabled auto-merge (squash) February 3, 2024 16:48

gvanrossum merged commit 94ec2b9 into python:main Feb 3, 2024
31 checks passed

bedevere-app bot removed the awaiting review label Feb 3, 2024

tjhowse added a commit to tjhowse/cpython that referenced this pull request Feb 3, 2024

pythongh-114887 Reject only sockets of type SOCK_STREAM in create_dat…

c293d03

…agram_endpoint() (python#114893) Also improve exception message. Co-authored-by: Donghee Na <donghee.na92@gmail.com>

tjhowse mentioned this pull request Feb 3, 2024

[3.11] gh-114887 Reject only sockets of type SOCK_STREAM in create_da… #114979

Merged

tjhowse mentioned this pull request Feb 3, 2024

[3.12] gh-114887 Reject only sockets of type SOCK_STREAM in create_da… #114980

Merged

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024

pythongh-114887 Reject only sockets of type SOCK_STREAM in create_dat…

3d713f6

…agram_endpoint() (python#114893) Also improve exception message. Co-authored-by: Donghee Na <donghee.na92@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-114887 Reject only sockets of type SOCK_STREAM in create_datagram_endpoint(), improve exception message. #114893

gh-114887 Reject only sockets of type SOCK_STREAM in create_datagram_endpoint(), improve exception message. #114893

tjhowse commented Feb 2, 2024 •

edited by bedevere-app bot

cpython-cla-bot bot commented Feb 2, 2024 •

edited

bedevere-app bot commented Feb 2, 2024

bedevere-app bot commented Feb 2, 2024

bedevere-app bot commented Feb 2, 2024

gvanrossum left a comment

gvanrossum commented Feb 3, 2024 •

edited by AlexWaygood

bedevere-bot commented Feb 3, 2024

tjhowse commented Feb 3, 2024

bedevere-app bot commented Feb 3, 2024

bedevere-app bot commented Feb 3, 2024

tjhowse commented Feb 3, 2024

gh-114887 Reject only sockets of type SOCK_STREAM in create_datagram_endpoint(), improve exception message. #114893

gh-114887 Reject only sockets of type SOCK_STREAM in create_datagram_endpoint(), improve exception message. #114893

Conversation

tjhowse commented Feb 2, 2024 • edited by bedevere-app bot

cpython-cla-bot bot commented Feb 2, 2024 • edited

bedevere-app bot commented Feb 2, 2024

bedevere-app bot commented Feb 2, 2024

bedevere-app bot commented Feb 2, 2024

gvanrossum left a comment

Choose a reason for hiding this comment

gvanrossum commented Feb 3, 2024 • edited by AlexWaygood

bedevere-bot commented Feb 3, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

tjhowse commented Feb 3, 2024

bedevere-app bot commented Feb 3, 2024

bedevere-app bot commented Feb 3, 2024

tjhowse commented Feb 3, 2024

tjhowse commented Feb 2, 2024 •

edited by bedevere-app bot

cpython-cla-bot bot commented Feb 2, 2024 •

edited

gvanrossum commented Feb 3, 2024 •

edited by AlexWaygood