Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101100: Fix dangling references in pickle.rst #114972

Merged
merged 3 commits into from
Feb 4, 2024
Merged

gh-101100: Fix dangling references in pickle.rst #114972

merged 3 commits into from
Feb 4, 2024

Conversation

smontanaro
Copy link
Contributor

@smontanaro smontanaro commented Feb 3, 2024 •
edited by github-actions bot
Loading

Fairly straightforward. Oddly enough, I found no canonical definition of append or extend methods, so I just. suppressed those links.

📚 Documentation preview 📚: https://cpython-previews--114972.org.readthedocs.build/

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Feb 3, 2024
@bedevere-app bedevere-app bot mentioned this pull request Feb 3, 2024
Open
AlexWaygood
AlexWaygood reviewed Feb 4, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Two small suggestions:

Doc/library/pickle.rst Outdated Show resolved Hide resolved
Doc/library/pickle.rst Outdated Show resolved Hide resolved
@smontanaro @AlexWaygood
Apply suggestions from code review
9583171 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! However, I'm unable to merge this PR (the "merge" button is physically unavailable to me right now 🙂) until the CI failure is fixed as part of this PR:

Congratulations! You improved:

Doc/library/pickle.rst

Please remove from Doc/tools/.nitignore

Error: Process completed with exit code 255.

Could you remove that line from Doc/tools/.nitignore?

@smontanaro
Copy link
Contributor Author

Could you remove that line from Doc/tools/.nitignore?

Should be good to go.

@AlexWaygood
Copy link
Member

Thanks!

@AlexWaygood AlexWaygood merged commit ec69e1d into python:main Feb 4, 2024
23 checks passed
@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Feb 4, 2024
@miss-islington-app
Copy link

Thanks @smontanaro for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @smontanaro for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 4, 2024
@smontanaro @AlexWaygood @miss-islington
pythongh-101100: Fix dangling references in pickle.rst (pythonGH-114972)
ce9d7f1 
(cherry picked from commit ec69e1d)

Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@miss-islington-app
Copy link

Sorry, @smontanaro and @AlexWaygood, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ec69e1d0ddc9906e0fb755a5234aeabdc96450ab 3.12

@bedevere-app
Copy link

bedevere-app bot commented Feb 4, 2024

GH-114992 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 4, 2024
@smontanaro smontanaro deleted the patch-10 branch February 4, 2024 14:26
AlexWaygood added a commit that referenced this pull request Feb 4, 2024
@miss-islington @smontanaro @AlexWaygood
[3.11] gh-101100: Fix dangling references in pickle.rst (GH-114972) (#…
55e5ae7 
…114992)

gh-101100: Fix dangling references in pickle.rst (GH-114972)
(cherry picked from commit ec69e1d)

Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
smontanaro added a commit to smontanaro/cpython that referenced this pull request Feb 4, 2024
@smontanaro
pythongh-101100: Fix dangling references in pickle.rst (python#114972)
bc59045 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit ec69e1d)
@bedevere-app
Copy link

bedevere-app bot commented Feb 4, 2024

GH-114999 is a backport of this pull request to the 3.11 branch.

@bedevere-app
Copy link

bedevere-app bot commented Feb 4, 2024

GH-114999 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Feb 4, 2024
AlexWaygood pushed a commit that referenced this pull request Feb 4, 2024
@smontanaro
[3.12] gh-101100: Fix dangling references in pickle.rst (#114972) (#1…
709a293 
…14999)

gh-101100: Fix dangling references in pickle.rst (#114972)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit ec69e1d)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@smontanaro @AlexWaygood @aisk
pythongh-101100: Fix dangling references in pickle.rst (python#114972)
bf7482d 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@smontanaro @AlexWaygood @fsc-eriker
pythongh-101100: Fix dangling references in pickle.rst (python#114972)
0513406 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

@AlexWaygood AlexWaygood

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smontanaro @AlexWaygood