Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-101100: Fix extending.rst #114981

Closed
wants to merge 0 commits into from
Closed

gh-101100: Fix extending.rst #114981

wants to merge 0 commits into from

Conversation

smontanaro
Copy link
Contributor

@smontanaro smontanaro commented Feb 4, 2024

Wrong data type for PyImport_Inittab


📚 Documentation preview 📚: https://cpython-previews--114981.org.readthedocs.build/

@smontanaro
Copy link
Contributor Author

I did nothing. Why does it think I did something? @hugovk or @AlexWaygood can you explain?

@AlexWaygood
Copy link
Member

It looks like you made this PR directly from your main branch. That's generally a bad idea — it can cause strange things like this to happen :)

I suggest always making a new branch for each PR you create on github

@smontanaro
Copy link
Contributor Author

What I've been doing with these small edits is to edit the file on python/cpython in GitHub. I guess I accidentally edited this one on smontanaro/cpython.

I find the whole manually create a new branch for each little change to be annoying, so for these small edits I've resorted to editing through the GitHub web interface. (I actually edit locally, remake html or htmllive, then check the result and paste the edited file into the web interface.)

@AlexWaygood
Copy link
Member

Specifically, it looks like you might have force-pushed to the main branch of your CPython clone to get it in sync with CPython's main branch. That then meant that there were 0 changes between your main branch and CPython's main branch; so, since this is a PR asking for changes from your main branch to be merged into CPython's main branch, github automatically closed the PR.

@smontanaro
Copy link
Contributor Author

Okay, I can buy that. I do remember accidentally committing some small doc change, then later issuing a git revert command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants