Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35704: Prevent test_shutil fail result when AIX is 32-bit and MAXDATA < 0x20000000 #11500

Merged
merged 4 commits into from Feb 18, 2019
Merged

bpo-35704: Prevent test_shutil fail result when AIX is 32-bit and MAXDATA < 0x20000000 #11500

merged 4 commits into from Feb 18, 2019

Conversation

aixtools
Copy link
Contributor

@aixtools aixtools commented Jan 10, 2019 •
edited by bedevere-bot

ncoghlan
ncoghlan requested changes Feb 17, 2019
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original version of the patch for bpo-35633 has snuck into this PR, so that needs to be reverted. The bpo-35704 itself looks fine to me, though - I just have one question regarding the availability of /usr/bin/dump on AIX systems.

Lib/test/test_shutil.py Show resolved Hide resolved
Lib/test/eintrdata/eintr_tester.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@aixtools
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ncoghlan: please review the changes made to this pull request.

@miss-islington miss-islington merged commit ef110b1 into python:master Feb 18, 2019
@ncoghlan
Copy link
Contributor

ncoghlan commented Feb 18, 2019 •
edited by bedevere-bot

Ah, d'oh, I was too hasty with the updated review, as the wrong NEWS entry got merged - the one for bpo-35704 got deleted, and the one for bpo-35633 was merged.

@ncoghlan ncoghlan mentioned this pull request Feb 18, 2019
Merged
miss-islington pushed a commit that referenced this pull request Feb 18, 2019
@ncoghlan @miss-islington
bpo-35704: Include correct NEWS entry (GH-11914)
02c04f2 
The wrong NEWS snippet was inadvertently included in
GH-11500, this switches to the correct one.


https://bugs.python.org/issue35704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aixtools @bedevere-bot @ncoghlan @the-knights-who-say-ni @miss-islington