gh-114099: Add preprocessor declarations to support compilation on iOS #115023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
requested review from
pganssle,
abalkin and
ericsnowcurrently
as code owners
mhsmith
reviewed
Feb 5, 2024
| if (uid == 501) { | ||
| struct passwd mp; | ||
| mp.pw_name = "mobile"; | ||
| mp.pw_passwd = "/smx7MYTQIi2M"; |
There was a problem hiding this comment.
I see it's easy enough to Google, but there should still be a comment explaining what this value is and where it comes from.
Comment on lines
+381
to
+384
| // iOS/tvOS/watchOS *define* some POSIX methods, | ||
| // but raise a compiler error if they are used. | ||
| #if TARGET_OS_IPHONE | ||
| # undef HAVE_GETGROUPS |
There was a problem hiding this comment.
If it's a compiler error, as opposed to a runtime error, then autoconf should be able to detect the problem. The comment should explain why that wasn't sufficient.
Comment on lines
+19
to
+21
| // tvOS and watchOS don't provide a number of important POSIX functions. | ||
| #if TARGET_OS_TV || TARGET_OS_WATCH | ||
| # undef HAVE_SIGALTSTACK |
Comment on lines
+47
to
+50
| // iOS/tvOS/watchOS *define* some POSIX methods, | ||
| // but raise a compiler error if they are used. | ||
| #if TARGET_OS_IPHONE | ||
| # undef HAVE_GETENTROPY |
Comment on lines
+66
to
+68
| // iOS/tvOS/watchOS *define* clock_settime, but it can't be used | ||
| #if TARGET_OS_IPHONE | ||
| # undef HAVE_CLOCK_SETTIME |
|
Prompted by @mhsmith's review, I've dug deeper into how/why configure was incorrectly identifying these functions, and I I've got a cleaner approach for most of this patch. Closing on that basis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the PEP 730 work to add iOS support.
Adds preprocessor declarations to C code to support compilation of the standard library on iOS/tvOS/watchOS.
These changes involve:
configure, but raise a compilation or runtime error if actually used..dylibextension on iOS dynamic librariesPLATFORM_TRIPLETbased on compiler behaviorThe preprocessor symbols used to identify Apple platforms are all provided by the
TargetConditionals.hheader, and form a heirarchy:TARGET_OS_IPHONE- Generated code will run on a variant of iOS (firmware, devices, simulator)TARGET_OS_IOS- Generated code will run on iOSTARGET_OS_MACCATALYST- Generated code will run on macOSTARGET_OS_TV- Generated code will run on tvOSTARGET_OS_WATCH- Generated code will run on watchOSTARGET_OS_SIMULATOR- Generated code will run on an iOS, tvOS, watchOS, or visionOS simulatorOf particular note:
TARGET_OS_IPHONEis any "iPhone like" device - including iOS, tvOS, watchOS, and visionOS.TARGET_OS_IOSis iOS only.