Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-115733: Fix crash involving exhausted list iterator #115740

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Feb 20, 2024

Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Eclips4 Eclips4 changed the title gh-115733: Fix crash involving exhausted iterator gh-115733: Fix crash involving exhausted list iterator Feb 20, 2024
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for the record, we worried about this issue at #114843, but since we detected this issue preemptively, it's fine!

@corona10 corona10 merged commit 520403e into python:main Feb 20, 2024
54 checks passed
@colesbury colesbury deleted the gh-115733-list-crash branch February 20, 2024 20:20
befeleme pushed a commit to fedora-python/cpython that referenced this pull request Feb 22, 2024
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants