Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-115773: Add tests to exercise the _Py_DebugOffsets structure #115774

Merged
merged 8 commits into from
Feb 28, 2024

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Feb 21, 2024

@pablogsal pablogsal changed the title bpo-115773: Add tests to exercise the _Py_DebugOffsets structure gh-115773: Add tests to exercise the _Py_DebugOffsets structure Feb 21, 2024
@pablogsal pablogsal force-pushed the external_inspection branch 3 times, most recently from 7e477c9 to 3583be6 Compare February 21, 2024 17:18
@pablogsal pablogsal requested a review from ambv February 21, 2024 17:19
@pablogsal pablogsal force-pushed the external_inspection branch 4 times, most recently from 4ced7ae to 53d4d57 Compare February 21, 2024 20:12
@pablogsal pablogsal marked this pull request as draft February 21, 2024 20:15
@pablogsal pablogsal force-pushed the external_inspection branch 2 times, most recently from fdb96bf to 0de2132 Compare February 21, 2024 22:06
@pablogsal pablogsal marked this pull request as ready for review February 21, 2024 23:28
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit a4ebf4e 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 23, 2024
@pablogsal
Copy link
Member Author

@erlend-aasland can you take a look? I think I have addressed all of the weird 32 bit failures

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Feb 23, 2024

I'll take a look tonight by sunday!

Modules/_testexternalinspection.c Outdated Show resolved Hide resolved
Modules/_testexternalinspection.c Outdated Show resolved Hide resolved
Include/internal/pycore_runtime.h Show resolved Hide resolved
Modules/_testexternalinspection.c Outdated Show resolved Hide resolved
Modules/_testexternalinspection.c Outdated Show resolved Hide resolved
Modules/_testexternalinspection.c Show resolved Hide resolved
Modules/_testexternalinspection.c Outdated Show resolved Hide resolved
Modules/_testexternalinspection.c Show resolved Hide resolved
Modules/_testexternalinspection.c Outdated Show resolved Hide resolved
Modules/_testexternalinspection.c Outdated Show resolved Hide resolved
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 27, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 55bf6ac 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 27, 2024
@pablogsal pablogsal merged commit 1752b51 into python:main Feb 28, 2024
117 of 118 checks passed
@pablogsal pablogsal deleted the external_inspection branch February 28, 2024 10:17
@gvanrossum
Copy link
Member

Did this break some JIT builds? See #116062 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants