Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-115937: remove extra processing for the __signature__ attribute #115984

Closed
wants to merge 1 commit into from

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Feb 27, 2024

((('a', ..., ..., 'positional_or_keyword'),
('b', 2, ..., 'positional_or_keyword')),
...))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should test that random objects should be passed as-is by the signature function (5, None, []...).
But maybe making this implementation perfect is not urgent as long as a decision has not been made as to what follow-up to bring to the base issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 42407ab there is also type check for returned sig object. So, my commit just returns things to pre-#100168 state (enum module tests kept).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this is long-standing behavior, but then it needs to be documented. (again, it can wait)

@erlend-aasland
Copy link
Contributor

Closing in favour of #116086. Thanks for your interest in improving CPython.

@skirpichev skirpichev deleted the enum-signature-115937 branch February 29, 2024 09:55
@skirpichev
Copy link
Contributor Author

Thanks for your interest in improving CPython.

Obviously, I'm not very good in this:)

@erlend-aasland
Copy link
Contributor

Obviously, I'm not very good in this:)

I think you've made a lot of very nice contributions, both code contributions, and as a participant in discussions. Sometimes we disagree, and that's ok. It is also often difficult to get a concensus within the core dev group. That's also ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants