Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-115821: [Enum] better error message for calling super().__new__() #116063

Merged
merged 4 commits into from
Feb 28, 2024
Merged

gh-115821: [Enum] better error message for calling super().__new__() #116063

merged 4 commits into from
Feb 28, 2024

Conversation

ethanfurman
Copy link
Member

@ethanfurman ethanfurman commented Feb 28, 2024 •
edited by bedevere-app bot

@ethanfurman
update docs and Enum
c5ed723 
docs now state to not call super().__new__
if super().__new__ is called, a better error message is now used
@ethanfurman
add tests
79c0e97
@ethanfurman ethanfurman added type-feature A feature request or enhancement stdlib Python modules in the Lib dir 3.13 bugs and security fixes labels Feb 28, 2024
@ethanfurman ethanfurman self-assigned this Feb 28, 2024
ethanfurman
ethanfurman commented Feb 28, 2024
View reviewed changes
Doc/library/enum.rst Outdated Show resolved Hide resolved
@bedevere-app bedevere-app bot mentioned this pull request Feb 28, 2024
Closed
@ethanfurman ethanfurman merged commit 3ea78fd into python:main Feb 28, 2024
31 checks passed
@ethanfurman ethanfurman deleted the enum-new_error_message branch February 28, 2024 23:19
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@ethanfurman @woodruffw
pythongh-115821: [Enum] better error message for calling super().__ne…
e49bd68 
…w__() (pythonGH-116063)

docs now state to not call super().__new__
if super().__new__ is called, a better error message is now used
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@ethanfurman @adorilson
pythongh-115821: [Enum] better error message for calling super().__ne…
dbe252e 
…w__() (pythonGH-116063)

docs now state to not call super().__new__
if super().__new__ is called, a better error message is now used
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@ethanfurman @diegorusso
pythongh-115821: [Enum] better error message for calling super().__ne…
b260b91 
…w__() (pythonGH-116063)

docs now state to not call super().__new__
if super().__new__ is called, a better error message is now used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ethanfurman ethanfurman

Labels
3.13 bugs and security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ethanfurman