Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-76785: Simplify Channels XID Types #116318

Merged

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Mar 4, 2024

I had added an extra cleanup abstraction a while back that has turned out to be unnecessary.

@ericsnowcurrently ericsnowcurrently enabled auto-merge (squash) March 4, 2024 19:14
@ericsnowcurrently ericsnowcurrently merged commit 01440d3 into python:main Mar 4, 2024
32 checks passed
@ericsnowcurrently ericsnowcurrently deleted the simplify-channels-xid-types branch March 4, 2024 19:36
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-wasi 3.x has failed when building commit 01440d3.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1046/builds/4510) and take a look at the build logs.
  4. Check if the failure is related to this commit (01440d3) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1046/builds/4510

Failed tests:

  • test_logging

Failed subtests:

  • test_rollover_at_midnight - test.test_logging.TimedRotatingFileHandlerTest.test_rollover_at_midnight

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/Lib/test/test_logging.py", line 6111, in test_rollover_at_midnight
    self.assertIn(f'testing2 {i}', line)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'testing2 0' not found in '2024-03-04 19:51:35,001 testing1 0\n'

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
I had added an extra cleanup abstraction a while back that has turned out to be unnecessary.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
I had added an extra cleanup abstraction a while back that has turned out to be unnecessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants