Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-114314: ctypes: remove stgdict and switch to heap types #116458

Merged
merged 60 commits into from Mar 20, 2024
Merged

gh-114314: ctypes: remove stgdict and switch to heap types #116458

merged 60 commits into from Mar 20, 2024

Commits on Mar 7, 2024

  1. Move paramfunc into a new struct, PyStgInfo 

    In this bootstrap commit, PyStgInfo is part of StgDictObject,
but that's a detail hidden by accessor functions.

(In the accessors, `state` is currently unused.)
    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6155211 View commit details
    Browse the repository at this point in the history

  2. Move the StgInfo out of StgDictObject and into the classes themselves

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    0171c30 View commit details
    Browse the repository at this point in the history

  3. Move StgInfo init/retrieval right after the corresponding StgDict one

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    acd91e9 View commit details
    Browse the repository at this point in the history

  4. Move size from StgDict to StgInfo

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    55af504 View commit details
    Browse the repository at this point in the history

  5. Move align from StgDict to StgInfo

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    27e5c50 View commit details
    Browse the repository at this point in the history

  6. Move length from StgDict to StgInfo, except for sizeof calculation

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    01bc637 View commit details
    Browse the repository at this point in the history

  7. Move part of the sizeof calculation

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    c8017e9 View commit details
    Browse the repository at this point in the history

  8. Move ffi_type_pointer from StgDict to StgInfo

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    40b012f View commit details
    Browse the repository at this point in the history

  9. Move proto from StgDict to StgInfo. Doesn't work just yet.

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    537defb View commit details
    Browse the repository at this point in the history

  10. Hack: Reserve space for StgInfo in static type objects

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ace6623 View commit details
    Browse the repository at this point in the history

  11. If StgInfo is not initialized, act as if it's not there

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6f775b9 View commit details
    Browse the repository at this point in the history

  12. Move getfunc & setfunc

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    4aaa06a View commit details
    Browse the repository at this point in the history

  13. Move argtypes

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6808524 View commit details
    Browse the repository at this point in the history

  14. Move converters

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    f031c00 View commit details
    Browse the repository at this point in the history

  15. Move restype

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    535176c View commit details
    Browse the repository at this point in the history

  16. Move checker

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    5260003 View commit details
    Browse the repository at this point in the history

  17. Move flags

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    0d3017e View commit details
    Browse the repository at this point in the history

  18. Move format

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    269b825 View commit details
    Browse the repository at this point in the history

  19. Move ndim

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    946f474 View commit details
    Browse the repository at this point in the history

  20. Move shape

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    607ed23 View commit details
    Browse the repository at this point in the history

  21. Replace more uses of StgDict

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    cb126b7 View commit details
    Browse the repository at this point in the history

  22. Don't pass dicts to PyCStgDict_clone

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    fd04c91 View commit details
    Browse the repository at this point in the history

  23. Don't set StgDict as type dict; use name attrdict for the type __di… 

    …ct__
    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8dce549 View commit details
    Browse the repository at this point in the history

  24. Remove more uses of StgDict

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6705e0e View commit details
    Browse the repository at this point in the history

  25. Remove StgDict

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8f99377 View commit details
    Browse the repository at this point in the history

  26. Remove StgDict from comments, names, and platform-specific code

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    daea3e5 View commit details
    Browse the repository at this point in the history

  27. Switch PyCSimpleType_new to _init

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    f67211f View commit details
    Browse the repository at this point in the history

  28. Switch _SimpleCData to a heap type

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    02aa9e1 View commit details
    Browse the repository at this point in the history

  29. Convert Struct and Union type _new to _init

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    13feac7 View commit details
    Browse the repository at this point in the history

  30. Switch PyCPointerType_new to _init

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    a68417b View commit details
    Browse the repository at this point in the history

  31. Switch PyCFuncPtrType_new to _init

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ad5d7b4 View commit details
    Browse the repository at this point in the history

  32. Switch CFuncPtr to heap type

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8d5e230 View commit details
    Browse the repository at this point in the history

  33. Switch Array to heap type

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    cdfae13 View commit details
    Browse the repository at this point in the history

  34. Switch _Pointer to a heap type

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    2d80960 View commit details
    Browse the repository at this point in the history

  35. Switch _ctypes.Union to heap type

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    3337ba4 View commit details
    Browse the repository at this point in the history

  36. Switch Structure to heap type

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    596cb89 View commit details
    Browse the repository at this point in the history

  37. Make the type-adding macros more regular

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    91feb64 View commit details
    Browse the repository at this point in the history

  38. Switch _CData to a heap type

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    77c64fe View commit details
    Browse the repository at this point in the history

  39. Visit/decref type in PyCData visit/dealloc

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    0be46a1 View commit details
    Browse the repository at this point in the history

  40. Remove _HackyHeapType

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9be3520 View commit details
    Browse the repository at this point in the history

  41. Decref attrdicts

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e523c2f View commit details
    Browse the repository at this point in the history

  42. Delegate CType_Type deallocation to PyType_Type.tp_dealloc

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    fb70e43 View commit details
    Browse the repository at this point in the history

  43. Fix Windows-specific crashes

    @neonene @encukou
    neonene authored and encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    cc59dea View commit details
    Browse the repository at this point in the history

  44. Update comments

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9bd9eb1 View commit details
    Browse the repository at this point in the history

  45. Add tests for metaclass details

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    946a0b1 View commit details
    Browse the repository at this point in the history

  46. Fix getting the module state

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    970b41d View commit details
    Browse the repository at this point in the history

  47. Add a blurb, even though this *should* not affect usage

    @encukou
    encukou committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    2a450ad View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Apply suggestions from code review 

    Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
    @encukou @neonene @erlend-aasland
    3 people committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    9878809 View commit details
    Browse the repository at this point in the history

  2. Inline PyStgInfo_From* & PyStgInfo_Init for performance

    @encukou
    encukou committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    b2ba89a View commit details
    Browse the repository at this point in the history

  3. Make CType_Type's clear & dealloc safer 

    Check that the state and st->PyCType_Type is set.
If they aren't, this will leak rather than crash.
    @encukou
    encukou committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    605c30c View commit details
    Browse the repository at this point in the history

  4. Remove self decrefs in error cases in init functions

    @encukou
    encukou committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    41dea1b View commit details
    Browse the repository at this point in the history

  5. Add static to PyType_Spec

    @encukou
    encukou committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    be0888f View commit details
    Browse the repository at this point in the history

  6. Remove redundant comment

    @encukou
    encukou committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    ac6eb38 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
    @encukou @erlend-aasland
    encukou and erlend-aasland committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    33be37f View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Fix comment 

    Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
    @encukou @neonene
    encukou and neonene committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    0b9d0a7 View commit details
    Browse the repository at this point in the history

  2. PyErr_WriteUnraisable clears the exception

    @encukou
    encukou committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    f02bad6 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Call tp_init for argument validation 

    Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
    @encukou @neonene
    encukou and neonene committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    16faac7 View commit details
    Browse the repository at this point in the history

  2. Add test for swapped type creation

    @neonene @encukou
    neonene authored and encukou committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2461e50 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ctypes-no-stgdict

    @encukou
    encukou committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ab90768 View commit details
    Browse the repository at this point in the history

  4. Fix test_swapped_type_creation

    @encukou
    encukou committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    de054af View commit details
    Browse the repository at this point in the history