Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-116600: [Enum] fix global Flag repr #116615

Merged
merged 4 commits into from Mar 11, 2024
Merged

gh-116600: [Enum] fix global Flag repr #116615

merged 4 commits into from Mar 11, 2024

Conversation

ethanfurman
Copy link
Member

@ethanfurman ethanfurman commented Mar 11, 2024 •
edited by bedevere-app bot

@ethanfurman ethanfurman added type-bug An unexpected behavior, bug, or error stdlib Python modules in the Lib dir 3.11 only security fixes 3.12 bugs and security fixes needs backport to 3.11 only security fixes 3.13 bugs and security fixes needs backport to 3.12 bug and security fixes labels Mar 11, 2024
@ethanfurman ethanfurman self-assigned this Mar 11, 2024
@bedevere-app bedevere-app bot mentioned this pull request Mar 11, 2024
Closed
@ethanfurman ethanfurman changed the title gh-116600: [Enum] fix global flag repr gh-116600: [Enum] fix global Flag repr Mar 11, 2024
serhiy-storchaka
serhiy-storchaka approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for a NEWS entry style nitpick.

Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst Outdated Show resolved Hide resolved
@ethanfurman @Eclips4
Update Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.F…
fed8ce8 
…cNBy_.rst

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@ethanfurman ethanfurman merged commit 06e29a2 into python:main Mar 11, 2024
32 checks passed
@miss-islington-app
Copy link

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2024
@ethanfurman @Eclips4 @miss-islington
pythongh-116600: [Enum] fix global Flag repr (pythonGH-116615)
1978d31 
* and fix global flag repr

* Update Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst

(cherry picked from commit 06e29a2)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@bedevere-app
Copy link

bedevere-app bot commented Mar 11, 2024

GH-116629 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Mar 11, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2024
@ethanfurman @Eclips4 @miss-islington
pythongh-116600: [Enum] fix global Flag repr (pythonGH-116615)
9f4e756 
* and fix global flag repr

* Update Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst

(cherry picked from commit 06e29a2)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@bedevere-app
Copy link

bedevere-app bot commented Mar 11, 2024

GH-116630 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 11, 2024
ethanfurman added a commit that referenced this pull request Mar 12, 2024
@miss-islington @ethanfurman @Eclips4
[3.12] gh-116600: [Enum] fix global Flag repr (GH-116615) (GH-116629)
1fb6615 
* and fix global flag repr

(cherry picked from commit 06e29a2)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
ethanfurman added a commit that referenced this pull request Mar 12, 2024
@miss-islington @ethanfurman @Eclips4
[3.11] gh-116600: [Enum] fix global Flag repr (GH-116615) (#116630)
5562a09 
* and fix global flag repr

(cherry picked from commit 06e29a2)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@ethanfurman @Eclips4 @adorilson
pythongh-116600: [Enum] fix global Flag repr (pythonGH-116615)
3bf35e8 
* and fix global flag repr

* Update Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@ethanfurman @Eclips4 @diegorusso
pythongh-116600: [Enum] fix global Flag repr (pythonGH-116615)
b3e58ed 
* and fix global flag repr

* Update Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eclips4 Eclips4 Eclips4 left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@ethanfurman ethanfurman

Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ethanfurman @serhiy-storchaka @Eclips4