Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-113317: Move warn() and fail() to libclinic.utils #116770

Merged
merged 1 commit into from Mar 14, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 13, 2024

@erlend-aasland
Copy link
Contributor

Would errors.py be a more fitting home for these?

@vstinner
Copy link
Member Author

Would errors.py be a more fitting home for these?

Right. I didn't notice this file. I updated my PR to move the two functions there.

@vstinner vstinner enabled auto-merge (squash) March 14, 2024 07:39
@vstinner vstinner merged commit a18c985 into python:main Mar 14, 2024
37 checks passed
@vstinner vstinner deleted the clinic_refactor branch March 14, 2024 08:07
@vstinner
Copy link
Member Author

Merged, thanks for the review @erlend-aasland.

vstinner added a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants