Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] gh-117187: Fix XML tests for vanilla Expat <2.6.0 (GH-117203) #117248

Merged
merged 1 commit into from
Mar 27, 2024
Merged

[3.8] gh-117187: Fix XML tests for vanilla Expat <2.6.0 (GH-117203) #117248

merged 1 commit into from
Mar 27, 2024

Commits on Mar 26, 2024

  1. pythongh-117187: Fix XML tests for vanilla Expat <2.6.0 (pythonGH-117203 

    )

This fixes XML unittest fallout from the python#115398 security fix.  When configured using `--with-system-expat` on systems with older pre 2.6.0 versions of libexpat, our unittests were failing.

* sax|etree: Simplify Expat version guard where simplifiable

Idea by Matěj Cepl

* sax|etree: Fix reparse deferral tests for vanilla Expat <2.6.0

This *does not fix* the case of distros with an older version of libexpat with the 2.6.0 feature backported as a security fix.  (Ubuntu is a known example of this with its libexpat1 2.5.0-2ubunutu0.1 package)
(cherry picked from commit 9f74e86)

Co-authored-by: Sebastian Pipping <sebastian@pipping.org>
    @hartwork @miss-islington
    hartwork authored and miss-islington committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    2ae9ae6 View commit details
    Browse the repository at this point in the history