Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12] gh-117110: Fix subclasses of typing.Any with custom constructors (GH-117111) #117357

Merged
merged 1 commit into from Mar 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 20 additions & 0 deletions Lib/test/test_typing.py
Expand Up @@ -141,6 +141,26 @@ class MockSomething(Something, Mock): pass
self.assertIsInstance(ms, Something)
self.assertIsInstance(ms, Mock)

def test_subclassing_with_custom_constructor(self):
class Sub(Any):
def __init__(self, *args, **kwargs): pass
# The instantiation must not fail.
Sub(0, s="")

def test_multiple_inheritance_with_custom_constructors(self):
class Foo:
def __init__(self, x):
self.x = x

class Bar(Any, Foo):
def __init__(self, x, y):
self.y = y
super().__init__(x)

b = Bar(1, 2)
self.assertEqual(b.x, 1)
self.assertEqual(b.y, 2)

def test_cannot_instantiate(self):
with self.assertRaises(TypeError):
Any()
Expand Down
2 changes: 1 addition & 1 deletion Lib/typing.py
Expand Up @@ -544,7 +544,7 @@ class Any(metaclass=_AnyMeta):
def __new__(cls, *args, **kwargs):
if cls is Any:
raise TypeError("Any cannot be instantiated")
return super().__new__(cls, *args, **kwargs)
return super().__new__(cls)


@_SpecialForm
Expand Down
@@ -0,0 +1 @@
Fix a bug that prevents subclasses of :class:`typing.Any` to be instantiated with arguments. Patch by Chris Fu.