Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-115142: Skip test_capi/test_opt.py if _testinternalcapi is not available #117574

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Apr 5, 2024

@encukou encukou merged commit 91d7605 into python:main Apr 11, 2024
37 checks passed
@miss-islington-app
Copy link

Thanks @Eclips4 for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry, @Eclips4 and @encukou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 91d7605ac3c15a185fd67921907cebaf0def1674 3.12

@encukou
Copy link
Member

encukou commented Apr 11, 2024

FWIW, test infrastructure changes are backported mainly to make it easier to backport future tests for bugfixes. If there's a conflict already, that reason goes away.
If you're fine with skipping the conflicting backports, feel free to skip them. (I'm not sure if 3.12 is important to your goal :)

@Eclips4
Copy link
Member Author

Eclips4 commented Apr 11, 2024

FWIW, test infrastructure changes are backported mainly to make it easier to backport future tests for bugfixes. If there's a conflict already, that reason goes away. If you're fine with skipping the conflicting backports, feel free to skip them. (I'm not sure if 3.12 is important to your goal :)

Shortly, yes, 3.12 is important for my goal :)
But in this case, test_capi/test_opt does not exist in 3.12, so there's no need in backport.
Thank you Petr for the explanation.

@Eclips4 Eclips4 deleted the issue-115142-test-opt branch April 11, 2024 18:47
@serhiy-storchaka
Copy link
Member

Earlier changes in test_capi were not backported to 3.11, and as the result, all following numerous changes and additions were not backported to 3.11. It is better to backport tests until it is too later.

@Eclips4
Copy link
Member Author

Eclips4 commented Apr 12, 2024

Earlier changes in test_capi were not backported to 3.11, and as the result, all following numerous changes and additions were not backported to 3.11. It is better to backport tests until it is too later.

I'm agree with you, Serhiy.
Sadly, these kinds of changes cannot be backported. test_opt tested _testinternalcapi.set_optimizer/get_optimizer/new_counter_optimizer and other functions that are not backported because they tested parts of the new tier2 implementation.

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backport to 3.12 bug and security fixes skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants