gh-111506: Error if the limited API is used in free-threaded build #117762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue a build time error if both `Py_LIMITED_API` and `Py_GIL_DISABLED` are defined.
vstinner
approved these changes
Apr 11, 2024
| @@ -45,6 +45,9 @@ | |||
| # endif | |||
| #endif | |||
|
|
|||
| #if defined(Py_LIMITED_API) && defined(Py_GIL_DISABLED) | |||
| # error "The limited API is not currently supported in the free-threaded build" | |||
There was a problem hiding this comment.
Would it be possible maybe to add a link for more information? Or issue number?
There was a problem hiding this comment.
I added a reference to the GH issue. We might want to consider adding a link to a HOWTO once we have more docs for the free-threaded build.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ild (python#117762) Issue a build time error if both `Py_LIMITED_API` and `Py_GIL_DISABLED` are defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue a build time error if both
Py_LIMITED_APIandPy_GIL_DISABLEDare defined.Without this, extensions may compile (with warnings), but crash on import.
--disable-gilbuilds are not compatible with the limited API #111506