Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-12317: Update the documentation for inspect.getabsfile() #11786

Closed
wants to merge 1 commit into from
Closed

bpo-12317: Update the documentation for inspect.getabsfile() #11786

wants to merge 1 commit into from

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Feb 8, 2019 •
edited by bedevere-bot

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 8, 2019
@corona10
Copy link
Member Author

corona10 commented Feb 8, 2019

@terryjreedy Please take a look!

terryjreedy
terryjreedy requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we document this function, the docstring and the derived doc entry should be modified. This should be on hold until core devs agree on what to do. See the issue.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@corona10 corona10 closed this Feb 23, 2019
@corona10 corona10 deleted the bpo-12317 branch February 23, 2019 16:50
@giampaolo giampaolo mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu eamanu left review comments

@terryjreedy terryjreedy terryjreedy requested changes

Assignees
No one assigned
Labels
awaiting changes DO-NOT-MERGE docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@corona10 @bedevere-bot @eamanu @terryjreedy @the-knights-who-say-ni