Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-112069: Make setiter_iternext to be thread-safe #117935

Merged
merged 2 commits into from
Apr 16, 2024
Merged

gh-112069: Make setiter_iternext to be thread-safe #117935

merged 2 commits into from
Apr 16, 2024

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Apr 16, 2024 •
edited by bedevere-app bot

@corona10 corona10 requested a review from colesbury April 16, 2024 15:44
@bedevere-app bedevere-app bot mentioned this pull request Apr 16, 2024
Closed
3 tasks
colesbury
colesbury approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One minor comment below

Objects/setobject.c Show resolved Hide resolved
@corona10 corona10 enabled auto-merge (squash) April 16, 2024 15:58
@corona10 corona10 merged commit a734fd5 into python:main Apr 16, 2024
33 of 34 checks passed
@corona10 corona10 deleted the gh-112069-set-iter branch April 16, 2024 17:15
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@corona10 @diegorusso
pythongh-112069: Make setiter_iternext to be thread-safe (pythongh-11…
854fe3e 
…7935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@corona10 @colesbury