Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-117225: Move colorize functionality to own internal module #118283

Merged
merged 5 commits into from May 1, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Apr 25, 2024

Here's the refactoring postponed from PR #117583.

Lib/_colorize.py Outdated Show resolved Hide resolved
Copy link
Contributor

@nineteendo nineteendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these newlines.

Lib/traceback.py Show resolved Hide resolved
Lib/test/support/__init__.py Show resolved Hide resolved
@hugovk hugovk marked this pull request as ready for review April 29, 2024 21:37
@hugovk
Copy link
Member Author

hugovk commented Apr 29, 2024

Somehow managed to find two free-threaded bugs with this PR, but they're fixed now.

@hugovk hugovk merged commit 3b3f8de into python:main May 1, 2024
35 checks passed
@hugovk hugovk deleted the doctest-refactor-colorize branch May 1, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants