Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-117680: Fix msvc warning in instruction_sequence.c #118326

Merged
merged 1 commit into from Apr 26, 2024

Conversation

neonene
Copy link
Contributor

@neonene neonene commented Apr 26, 2024

Fixes the following Windows-specific warning since #117629:

 Warning: ...\Windows Kits\10\Include\10.0.22621.0\um\wingdi.h(118,1):
 warning C4005: 'ERROR': macro redefinition [D:\a\...
         (compiling source file '../Python/instruction_sequence.c')
         D:\a\cpython\cpython\Python\instruction_sequence.c(26,1):
         see previous definition of 'ERROR'

wingdi.h:

/* Region Flags */
#define ERROR               0
#define NULLREGION          1
...

cc @iritkatriel

Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@iritkatriel iritkatriel merged commit 63add11 into python:main Apr 26, 2024
38 checks passed
@neonene neonene deleted the redefine branch April 26, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants